Commit 0d32f177 authored Nov 26, 2018 by Xin Long Committed by David S. Miller Nov 27, 2018

sctp: increase sk_wmem_alloc when head->truesize is increased



I changed to count sk_wmem_alloc by skb truesize instead of 1 to
fix the sk_wmem_alloc leak caused by later truesize's change in
xfrm in Commit 02968ccf ("sctp: count sk_wmem_alloc by skb
truesize in sctp_packet_transmit").

But I should have also increased sk_wmem_alloc when head->truesize
is increased in sctp_packet_gso_append() as xfrm does. Otherwise,
sctp gso packet will cause sk_wmem_alloc underflow.

Fixes: 02968ccf ("sctp: count sk_wmem_alloc by skb truesize in sctp_packet_transmit")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a8842e97

net/sctp/output.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -410,6 +410,7 @@ static void sctp_packet_gso_append(struct sk_buff head, struct sk_buff skb)
		head->truesize += skb->truesize;
		head->data_len += skb->len;
		head->len += skb->len;
		refcount_add(skb->truesize, &head->sk->sk_wmem_alloc);

		__skb_header_release(skb);
		}

Admin message