Commit 0d200aef authored Jul 03, 2012 by Joe Thornber Committed by Alasdair G Kergon Jul 03, 2012

dm thin: commit metadata before creating metadata snapshot



Userland sometimes sees a corrupt metadata block if metadata is changing
rapidly when a metadata snapshot is reserved for userland,  To make the
problem go away, commit before we take the metadata snapshot (which is a
sensible thing to do anyway).

The checksums mean userland spots this corruption immediately so there's
no risk of acting on incorrect data.  No corruption exists from the
kernel's point of view, and thin_check passes after pool shutdown.

I believe this is to do with shared blocks at the first level of the
{device, mapping} btree.  Prior to the metadata-snap support no sharing
at this level was possible, so this patch is only required after commit
cc8394d8 ("dm thin: provide userspace
access to pool metadata").

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>

parent 6887a413

drivers/md/dm-thin.c

+7 −0

Original line number	Diff line number	Diff line
		@@ -2292,6 +2292,13 @@ static int process_reserve_metadata_snap_mesg(unsigned argc, char **argv, struct
		if (r)
		return r;

		r = dm_pool_commit_metadata(pool->pmd);
		if (r) {
		DMERR("%s: dm_pool_commit_metadata() failed, error = %d",
		__func__, r);
		return r;
		}

		r = dm_pool_reserve_metadata_snap(pool->pmd);
		if (r)
		DMWARN("reserve_metadata_snap message failed.");

Admin message