Commit 0ce4a85f authored by Lu Baolu's avatar Lu Baolu Committed by Joerg Roedel
Browse files

Revert "iommu/vt-d: Avoid duplicated pci dma alias consideration" 

This reverts commit 55752949.

Commit 55752949 ("iommu/vt-d: Avoid duplicated pci dma alias
consideration") aimed to address a NULL pointer deference issue
happened when a thunderbolt device driver returned unexpectedly.

Unfortunately, this change breaks a previous pci quirk added by
commit cc346a47 ("PCI: Add function 1 DMA alias quirk for
Marvell devices"), as the result, devices like Marvell 88SE9128
SATA controller doesn't work anymore.

We will continue to try to find the real culprit mentioned in
55752949, but for now we should revert it to fix current
breakage.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204627


Cc: Stijn Tintel <stijn@linux-ipv6.be>
Cc: Petr Vandrovec <petr@vandrovec.name>
Reported-by: default avatarStijn Tintel <stijn@linux-ipv6.be>
Reported-by: default avatarPetr Vandrovec <petr@vandrovec.name>
Signed-off-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent a55aa89a

drivers/iommu/intel-iommu.c

+53 −2
Original line number Diff line number Diff line
@@ -339,6 +339,8 @@ static void domain_exit(struct dmar_domain *domain); 
static void domain_remove_dev_info(struct dmar_domain *domain);

static void dmar_remove_one_dev_info(struct device *dev);

static void __dmar_remove_one_dev_info(struct device_domain_info *info);

static void domain_context_clear(struct intel_iommu *iommu,

				 struct device *dev);

static int domain_detach_iommu(struct dmar_domain *domain,

			       struct intel_iommu *iommu);

static bool device_is_rmrr_locked(struct device *dev);
@@ -2105,9 +2107,26 @@ out_unlock: 
	return ret;

}



struct domain_context_mapping_data {

	struct dmar_domain *domain;

	struct intel_iommu *iommu;

	struct pasid_table *table;

};



static int domain_context_mapping_cb(struct pci_dev *pdev,

				     u16 alias, void *opaque)

{

	struct domain_context_mapping_data *data = opaque;



	return domain_context_mapping_one(data->domain, data->iommu,

					  data->table, PCI_BUS_NUM(alias),

					  alias & 0xff);

}



static int

domain_context_mapping(struct dmar_domain *domain, struct device *dev)

{

	struct domain_context_mapping_data data;

	struct pasid_table *table;

	struct intel_iommu *iommu;

	u8 bus, devfn;
@@ -2117,7 +2136,17 @@ domain_context_mapping(struct dmar_domain *domain, struct device *dev) 
		return -ENODEV;



	table = intel_pasid_get_table(dev);

	return domain_context_mapping_one(domain, iommu, table, bus, devfn);



	if (!dev_is_pci(dev))

		return domain_context_mapping_one(domain, iommu, table,

						  bus, devfn);



	data.domain = domain;

	data.iommu = iommu;

	data.table = table;



	return pci_for_each_dma_alias(to_pci_dev(dev),

				      &domain_context_mapping_cb, &data);

}



static int domain_context_mapped_cb(struct pci_dev *pdev,
@@ -4759,6 +4788,28 @@ out_free_dmar: 
	return ret;

}



static int domain_context_clear_one_cb(struct pci_dev *pdev, u16 alias, void *opaque)

{

	struct intel_iommu *iommu = opaque;



	domain_context_clear_one(iommu, PCI_BUS_NUM(alias), alias & 0xff);

	return 0;

}



/*

 * NB - intel-iommu lacks any sort of reference counting for the users of

 * dependent devices.  If multiple endpoints have intersecting dependent

 * devices, unbinding the driver from any one of them will possibly leave

 * the others unable to operate.

 */

static void domain_context_clear(struct intel_iommu *iommu, struct device *dev)

{

	if (!iommu || !dev || !dev_is_pci(dev))

		return;



	pci_for_each_dma_alias(to_pci_dev(dev), &domain_context_clear_one_cb, iommu);

}



static void __dmar_remove_one_dev_info(struct device_domain_info *info)

{

	struct dmar_domain *domain;
@@ -4779,7 +4830,7 @@ static void __dmar_remove_one_dev_info(struct device_domain_info *info) 
					PASID_RID2PASID);



		iommu_disable_dev_iotlb(info);

		domain_context_clear_one(iommu, info->bus, info->devfn);

		domain_context_clear(iommu, info->dev);

		intel_pasid_free_table(info->dev);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE