Commit 0c9539a4 authored Mar 28, 2017 by Omar Sandoval Committed by Jens Axboe Mar 29, 2017

blk-mq: fix leak of q->stats



blk_alloc_queue_node() already allocates q->stats, so
blk_mq_init_allocated_queue() is overwriting it with a new allocation.

Fixes: a83b576c ("block: fix stacked driver stats init and free")
Reviewed-by: Ming Lei <tom.leiming@gmail.com>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 334335d2

block/blk-mq.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -2234,10 +2234,6 @@ struct request_queue blk_mq_init_allocated_queue(struct blk_mq_tag_set set,
		/* mark the queue as mq asap */
		q->mq_ops = set->ops;

		q->stats = blk_alloc_queue_stats();
		if (!q->stats)
		goto err_exit;

		q->poll_cb = blk_stat_alloc_callback(blk_mq_poll_stats_fn,
		blk_stat_rq_ddir, 2, q);
		if (!q->poll_cb)

Admin message