Commit 0c8946d9 authored Oct 13, 2008 by David Miller Committed by Linus Torvalds Oct 13, 2008

serial: Make uart_port's ioport "unsigned long".



Otherwise the top 32-bits of the resource value get chopped
off on 64-bit systems, and the resulting I/O accesses go to
random places.

Thanks to testing and debugging by Josip Rodin, which helped
track this down.

Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 7459b6ff

include/linux/serial_core.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -241,7 +241,7 @@ typedef unsigned int __bitwise__ upf_t;

		struct uart_port {
		spinlock_t lock; /* port lock */
		unsigned int iobase; /* in/out[bwl] */
		unsigned long iobase; /* in/out[bwl] */
		unsigned char __iomem membase; / read/write[bwl] */
		unsigned int irq; /* irq number */
		unsigned int uartclk; /* base uart clock */

Admin message