Commit 0c796f91 authored Sep 16, 2010 by Dan Rosenberg Committed by David S. Miller Sep 16, 2010

drivers/net/tulip/de4x5.c: fix union member name in DE4X5_GET_REG ioctl



This was previously reported as a security issue due to leakage of
uninitialized stack memory.  Jeff Mahoney pointed out that this is
incorrect since the copied data is from a union (rather than a struct).
Therefore, this patch is only under consideration for the sake of
correctness, and is not security relevant. 

Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Acked-by: Grant Grundler <grundler@parisc-linux.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cd13539b

drivers/net/tulip/de4x5.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -5474,7 +5474,7 @@ de4x5_ioctl(struct net_device dev, struct ifreq rq, int cmd)
		tmp.lval[6] = inl(DE4X5_STRR); j+=4;
		tmp.lval[7] = inl(DE4X5_SIGR); j+=4;
		ioc->len = j;
		if (copy_to_user(ioc->data, tmp.addr, ioc->len)) return -EFAULT;
		if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT;
		break;

		#define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */

Admin message