Commit 0c6df590 authored by Quinn Tran's avatar Quinn Tran Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix abort timeout race condition. 



If an abort times out, the Abort IOCB completion and Abort timer can race
against each other. This patch provides unique error code for timer path to
allow proper cleanup.

[mkp: typo]

Signed-off-by: default avatarQuinn Tran <qutran@marvell.com>
Signed-off-by: default avatarHimanshu Madhani <hmadhani@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d376dbda

drivers/scsi/qla2xxx/qla_def.h

+1 −0
Original line number Diff line number Diff line
@@ -4628,6 +4628,7 @@ struct secure_flash_update_block_pk { 
#define QLA_SUSPENDED			0x106

#define QLA_BUSY			0x107

#define QLA_ALREADY_REGISTERED		0x109

#define QLA_OS_TIMER_EXPIRED		0x10a



#define NVRAM_DELAY()		udelay(10)

drivers/scsi/qla2xxx/qla_init.c

+16 −2
Original line number Diff line number Diff line
@@ -99,9 +99,22 @@ static void qla24xx_abort_iocb_timeout(void *data) 
{

	srb_t *sp = data;

	struct srb_iocb *abt = &sp->u.iocb_cmd;

	struct qla_qpair *qpair = sp->qpair;

	u32 handle;

	unsigned long flags;



	spin_lock_irqsave(qpair->qp_lock_ptr, flags);

	for (handle = 1; handle < qpair->req->num_outstanding_cmds; handle++) {

		/* removing the abort */

		if (qpair->req->outstanding_cmds[handle] == sp) {

			qpair->req->outstanding_cmds[handle] = NULL;

			break;

		}

	}

	spin_unlock_irqrestore(qpair->qp_lock_ptr, flags);



	abt->u.abt.comp_status = CS_TIMEOUT;

	sp->done(sp, QLA_FUNCTION_TIMEOUT);

	sp->done(sp, QLA_OS_TIMER_EXPIRED);

}



static void qla24xx_abort_sp_done(void *ptr, int res)
@@ -109,7 +122,8 @@ static void qla24xx_abort_sp_done(void *ptr, int res) 
	srb_t *sp = ptr;

	struct srb_iocb *abt = &sp->u.iocb_cmd;



	if (del_timer(&sp->u.iocb_cmd.timer)) {

	if ((res == QLA_OS_TIMER_EXPIRED) ||

	    del_timer(&sp->u.iocb_cmd.timer)) {

		if (sp->flags & SRB_WAKEUP_ON_COMP)

			complete(&abt->u.abt.comp);

		else

CRA Git | Maintained and supported by SUSTech CRA and CCSE