staging: rtl8188eu: remove else after return (0c5e99c9) · Commits · 戴 / test

Remove else after return in rtl88eu_dm_antenna_diversity() to improve readability and clear a checkpatch warning. WARNING: else is not generally useful after a break or return Signed-off-by:

Michael Straube <straube.linux@gmail.com> Link: https://lore.kernel.org/r/20200105194936.5477-1-straube.linux@gmail.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/rtl8188eu/hal/odm_rtl8188e.c

+14 −12

Original line number	Diff line number	Diff line
		@@ -303,6 +303,7 @@ void rtl88eu_dm_antenna_diversity(struct odm_dm_struct *dm_odm)

		if (!(dm_odm->SupportAbility & ODM_BB_ANT_DIV))
		return;

		if (!dm_odm->bLinked) {
		ODM_RT_TRACE(dm_odm, ODM_COMP_ANT_DIV, ODM_DBG_LOUD,
		("ODM_AntennaDiversity_88E(): No Link.\n"));
		@@ -318,7 +319,8 @@ void rtl88eu_dm_antenna_diversity(struct odm_dm_struct *dm_odm)
		dm_fat_tbl->bBecomeLinked = dm_odm->bLinked;
		}
		return;
		} else {
		}

		if (!dm_fat_tbl->bBecomeLinked) {
		ODM_RT_TRACE(dm_odm, ODM_COMP_ANT_DIV, ODM_DBG_LOUD,
		("Need to Turn on HW AntDiv\n"));
		@@ -330,7 +332,7 @@ void rtl88eu_dm_antenna_diversity(struct odm_dm_struct *dm_odm)
		BIT(21), 1);
		dm_fat_tbl->bBecomeLinked = dm_odm->bLinked;
		}
		}

		if ((dm_odm->AntDivType == CG_TRX_HW_ANTDIV) \|\|
		(dm_odm->AntDivType == CGCS_RX_HW_ANTDIV))
		rtl88eu_dm_hw_ant_div(dm_odm);

Admin message