Commit 0c4da70c authored Nov 26, 2019 by Omar Sandoval Committed by Darrick J. Wong Dec 02, 2019

xfs: fix realtime file data space leak



Realtime files in XFS allocate extents in rextsize units. However, the
written/unwritten state of those extents is still tracked in blocksize
units. Therefore, a realtime file can be split up into written and
unwritten extents that are not necessarily aligned to the realtime
extent size. __xfs_bunmapi() has some logic to handle these various
corner cases. Consider how it handles the following case:

1. The last extent is unwritten.
2. The last extent is smaller than the realtime extent size.
3. startblock of the last extent is not aligned to the realtime extent
   size, but startblock + blockcount is.

In this case, __xfs_bunmapi() calls xfs_bmap_add_extent_unwritten_real()
to set the second-to-last extent to unwritten. This should merge the
last and second-to-last extents, so __xfs_bunmapi() moves on to the
second-to-last extent.

However, if the size of the last and second-to-last extents combined is
greater than MAXEXTLEN, xfs_bmap_add_extent_unwritten_real() does not
merge the two extents. When that happens, __xfs_bunmapi() skips past the
last extent without unmapping it, thus leaking the space.

Fix it by only unwriting the minimum amount needed to align the last
extent to the realtime extent size, which is guaranteed to merge with
the last extent.

Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 8feb4732

fs/xfs/libxfs/xfs_bmap.c

+14 −11

Original line number	Diff line number	Diff line
		@@ -5480,16 +5480,17 @@ __xfs_bunmapi(
		}
		div_u64_rem(del.br_startblock, mp->m_sb.sb_rextsize, &mod);
		if (mod) {
		xfs_extlen_t off = mp->m_sb.sb_rextsize - mod;

		/*
		* Realtime extent is lined up at the end but not
		* at the front. We'll get rid of full extents if
		* we can.
		*/
		mod = mp->m_sb.sb_rextsize - mod;
		if (del.br_blockcount > mod) {
		del.br_blockcount -= mod;
		del.br_startoff += mod;
		del.br_startblock += mod;
		if (del.br_blockcount > off) {
		del.br_blockcount -= off;
		del.br_startoff += off;
		del.br_startblock += off;
		} else if (del.br_startoff == start &&
		(del.br_state == XFS_EXT_UNWRITTEN \|\|
		tp->t_blk_res == 0)) {
		@@ -5507,6 +5508,7 @@ __xfs_bunmapi(
		continue;
		} else if (del.br_state == XFS_EXT_UNWRITTEN) {
		struct xfs_bmbt_irec prev;
		xfs_fileoff_t unwrite_start;

		/*
		* This one is already unwritten.
		@@ -5520,12 +5522,13 @@ __xfs_bunmapi(
		ASSERT(!isnullstartblock(prev.br_startblock));
		ASSERT(del.br_startblock ==
		prev.br_startblock + prev.br_blockcount);
		if (prev.br_startoff < start) {
		mod = start - prev.br_startoff;
		prev.br_blockcount -= mod;
		unwrite_start = max3(start,
		del.br_startoff - mod,
		prev.br_startoff);
		mod = unwrite_start - prev.br_startoff;
		prev.br_startoff = unwrite_start;
		prev.br_startblock += mod;
		prev.br_startoff = start;
		}
		prev.br_blockcount -= mod;
		prev.br_state = XFS_EXT_UNWRITTEN;
		error = xfs_bmap_add_extent_unwritten_real(tp,
		ip, whichfork, &icur, &cur,

Admin message