Commit 0c450b8e authored Nov 20, 2020 by Finn Thain Committed by Geert Uytterhoeven Nov 23, 2020

m68k: mac: Remove redundant VIA register writes



There's no need to write the same value to the timer latch and timer
counter registers. Values written to the counter registers get stored
in the latches anyway. The write to vT1CH copies the latch values to
the counter.

Cc: Joshua Thompson <funaho@jurai.org>
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Link: https://lore.kernel.org/r/c6b1d9620af3e8f89dd0157a41fa4147294b251d.1605847196.git.fthain@telegraphics.com.au


Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

parent 471037e2

arch/m68k/mac/via.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -169,8 +169,6 @@ void __init via_init(void)

		via1[vIER] = 0x7F;
		via1[vIFR] = 0x7F;
		via1[vT1LL] = 0;
		via1[vT1LH] = 0;
		via1[vT1CL] = 0;
		via1[vT1CH] = 0;
		via1[vT2CL] = 0;
		@@ -225,8 +223,6 @@ void __init via_init(void)
		via2[gIER] = 0x7F;
		via2[gIFR] = 0x7F \| rbv_clear;
		if (!rbv_present) {
		via2[vT1LL] = 0;
		via2[vT1LH] = 0;
		via2[vT1CL] = 0;
		via2[vT1CH] = 0;
		via2[vT2CL] = 0;
		@@ -604,8 +600,6 @@ void __init via_init_clock(irq_handler_t timer_routine)
		return;
		}

		via1[vT1LL] = VIA_TC_LOW;
		via1[vT1LH] = VIA_TC_HIGH;
		via1[vT1CL] = VIA_TC_LOW;
		via1[vT1CH] = VIA_TC_HIGH;
		via1[vACR] \|= 0x40;

Admin message