Commit 0c42a55c authored by Antti Palosaari's avatar Antti Palosaari Committed by Mauro Carvalho Chehab
Browse files

[media] em28xx: do not set PCTV 290e LNA handler if fe attach fail



It was a bug that could cause oops if demodulator attach was
failed.

Signed-off-by: default avatarAntti Palosaari <crope@iki.fi>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a36a66d7
Loading
Loading
Loading
Loading
+13 −11
Original line number Diff line number Diff line
@@ -1002,20 +1002,22 @@ static int em28xx_dvb_init(struct em28xx *dev)
				result = -EINVAL;
				goto out_free;
			}
		}

#ifdef CONFIG_GPIOLIB
			/* enable LNA for DVB-T, DVB-T2 and DVB-C */
		result = gpio_request_one(dvb->lna_gpio, GPIOF_OUT_INIT_LOW,
				NULL);
			result = gpio_request_one(dvb->lna_gpio,
					GPIOF_OUT_INIT_LOW, NULL);
			if (result)
			em28xx_errdev("gpio request failed %d\n", result);
				em28xx_errdev("gpio request failed %d\n",
						result);
			else
				gpio_free(dvb->lna_gpio);

			result = 0; /* continue even set LNA fails */
#endif
			dvb->fe[0]->ops.set_lna = em28xx_pctv_290e_set_lna;
		}

		break;
	case EM2884_BOARD_HAUPPAUGE_WINTV_HVR_930C:
	{