Commit 0c35c674 authored Apr 05, 2020 by Markus Elfring Committed by Michael S. Tsirkin Jun 02, 2020

virtio-mmio: Delete an error message in vm_find_vqs()



The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Link: https://lore.kernel.org/r/9e27bc4a-cfa1-7818-dc25-8ad308816b30@web.de


Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

parent e7c8cc35

drivers/virtio/virtio_mmio.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -466,10 +466,8 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs,
		int irq = platform_get_irq(vm_dev->pdev, 0);
		int i, err, queue_idx = 0;

		if (irq < 0) {
		dev_err(&vdev->dev, "Cannot get IRQ resource\n");
		if (irq < 0)
		return irq;
		}

		err = request_irq(irq, vm_interrupt, IRQF_SHARED,
		dev_name(&vdev->dev), vm_dev);

Admin message