Commit 0bfdf286 authored by Guangbin Huang's avatar Guangbin Huang Committed by David S. Miller
Browse files

net: hns3: optimize local variable initialization 



The variable tx_ring is unnecessary to be initialized as it will be set
before used, and the variable rst_cnt is better to be initialized when
declaration for simplification.

Signed-off-by: default avatarGuangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e4b806ed

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1771,7 +1771,7 @@ static bool hns3_get_tx_timeo_queue_info(struct net_device *ndev) 
{

{

	struct hns3_nic_priv *priv = netdev_priv(ndev);

	struct hns3_nic_priv *priv = netdev_priv(ndev);

	struct hnae3_handle *h = hns3_get_handle(ndev);

	struct hnae3_handle *h = hns3_get_handle(ndev);

	struct hns3_enet_ring *tx_ring = NULL;

	struct hns3_enet_ring *tx_ring;

	struct napi_struct *napi;

	struct napi_struct *napi;

	int timeout_queue = 0;

	int timeout_queue = 0;

	int hw_head, hw_tail;

	int hw_head, hw_tail;

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -8992,10 +8992,9 @@ static int hclge_init_nic_client_instance(struct hnae3_ae_dev *ae_dev, 
{

{

	struct hnae3_client *client = vport->nic.client;

	struct hnae3_client *client = vport->nic.client;

	struct hclge_dev *hdev = ae_dev->priv;

	struct hclge_dev *hdev = ae_dev->priv;

	int rst_cnt;

	int rst_cnt = hdev->rst_stats.reset_cnt;

	int ret;

	int ret;





	rst_cnt = hdev->rst_stats.reset_cnt;

	ret = client->ops->init_instance(&vport->nic);

	ret = client->ops->init_instance(&vport->nic);

	if (ret)

	if (ret)

		return ret;

		return ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE