Commit 0bed9b5c authored by Sage Weil's avatar Sage Weil
Browse files

libceph: add update_authorizer auth method 

Currently the messenger calls out to a get_authorizer con op, which will
create a new authorizer if it doesn't yet have one.  In the meantime, when
we rotate our service keys, the authorizer doesn't get updated.  Eventually
it will be rejected by the server on a new connection attempt and get
invalidated, and we will then rebuild a new authorizer, but this is not
ideal.

Instead, if we do have an authorizer, call a new update_authorizer op that
will verify that the current authorizer is using the latest secret.  If it
is not, we will build a new one that does.  This avoids the transient
failure.

This fixes one of the sorry sequence of events for bug

	http://tracker.ceph.com/issues/4282



Signed-off-by: default avatarSage Weil <sage@inktank.com>
Reviewed-by: default avatarAlex Elder <elder@inktank.com>
parent 4b8e8b5d

fs/ceph/mds_client.c

+6 −1
Original line number Diff line number Diff line
@@ -3448,6 +3448,11 @@ static struct ceph_auth_handshake *get_authorizer(struct ceph_connection *con, 
						     auth);

		if (ret)

			return ERR_PTR(ret);

	} else if (ac->ops && ac->ops_update_authorizer) {

		int ret = ac->ops->update_authorizer(ac, CEPH_ENTITY_TYPE_MDS,

						     auth);

		if (ret)

			return ERR_PTR(ret);

	}

	*proto = ac->protocol;

include/linux/ceph/auth.h

+3 −0
Original line number Diff line number Diff line
@@ -52,6 +52,9 @@ struct ceph_auth_client_ops { 
	 */

	int (*create_authorizer)(struct ceph_auth_client *ac, int peer_type,

				 struct ceph_auth_handshake *auth);

	/* ensure that an existing authorizer is up to date */

	int (*update_authorizer)(struct ceph_auth_client *ac, int peer_type,

				 struct ceph_auth_handshake *auth);

	int (*verify_authorizer_reply)(struct ceph_auth_client *ac,

				       struct ceph_authorizer *a, size_t len);

	void (*destroy_authorizer)(struct ceph_auth_client *ac,

net/ceph/auth_x.c

+23 −0
Original line number Diff line number Diff line
@@ -298,6 +298,7 @@ static int ceph_x_build_authorizer(struct ceph_auth_client *ac, 
			return -ENOMEM;

	}

	au->service = th->service;

	au->secret_id = th->secret_id;



	msg_a = au->buf->vec.iov_base;

	msg_a->struct_v = 1;
@@ -555,6 +556,27 @@ static int ceph_x_create_authorizer( 
	return 0;

}



static int ceph_x_update_authorizer(

	struct ceph_auth_client *ac, int peer_type,

	struct ceph_auth_handshake *auth)

{

	struct ceph_x_authorizer *au;

	struct ceph_x_ticket_handler *th;

	int ret;



	th = get_ticket_handler(ac, peer_type);

	if (IS_ERR(th))

		return PTR_ERR(th);



	au = (struct ceph_x_authorizer *)auth->authorizer;

	if (au->secret_id < th->secret_id) {

		dout("ceph_x_update_authorizer service %u secret %llu < %llu\n",

		     au->service, au->secret_id, th->secret_id);

		return ceph_x_build_authorizer(ac, th, au);

	}

	return 0;

}



static int ceph_x_verify_authorizer_reply(struct ceph_auth_client *ac,

					  struct ceph_authorizer *a, size_t len)

{
@@ -641,6 +663,7 @@ static const struct ceph_auth_client_ops ceph_x_ops = { 
	.build_request = ceph_x_build_request,

	.handle_reply = ceph_x_handle_reply,

	.create_authorizer = ceph_x_create_authorizer,

	.update_authorizer = ceph_x_update_authorizer,

	.verify_authorizer_reply = ceph_x_verify_authorizer_reply,

	.destroy_authorizer = ceph_x_destroy_authorizer,

	.invalidate_authorizer = ceph_x_invalidate_authorizer,

net/ceph/auth_x.h

+1 −0
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ struct ceph_x_authorizer { 
	struct ceph_buffer *buf;

	unsigned int service;

	u64 nonce;

	u64 secret_id;

	char reply_buf[128];  /* big enough for encrypted blob */

};

net/ceph/osd_client.c

+5 −0
Original line number Diff line number Diff line
@@ -2220,6 +2220,11 @@ static struct ceph_auth_handshake *get_authorizer(struct ceph_connection *con, 
							auth);

		if (ret)

			return ERR_PTR(ret);

	} else if (ac->ops && ac->ops->update_authorizer) {

		int ret = ac->ops->update_authorizer(ac, CEPH_ENTITY_TYPE_OSD,

						     auth);

		if (ret)

			return ERR_PTR(ret);

	}

	*proto = ac->protocol;

CRA Git | Maintained and supported by SUSTech CRA and CCSE