thermal: int3400_thermal: fix error handling in int3400_thermal_probe() (0be86969) · Commits · 戴 / test

There are resources that are not dealocated on failure path in int3400_thermal_probe(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by:

Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by:

Zhang Rui <rui.zhang@intel.com>

drivers/thermal/int340x_thermal/int3400_thermal.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -319,17 +319,21 @@ static int int3400_thermal_probe(struct platform_device *pdev)

		result = sysfs_create_group(&pdev->dev.kobj, &uuid_attribute_group);
		if (result)
		goto free_zone;
		goto free_rel_misc;

		result = acpi_install_notify_handler(
		priv->adev->handle, ACPI_DEVICE_NOTIFY, int3400_notify,
		(void *)priv);
		if (result)
		goto free_zone;
		goto free_sysfs;

		return 0;

		free_zone:
		free_sysfs:
		sysfs_remove_group(&pdev->dev.kobj, &uuid_attribute_group);
		free_rel_misc:
		if (!priv->rel_misc_dev_res)
		acpi_thermal_rel_misc_device_remove(priv->adev->handle);
		thermal_zone_device_unregister(priv->thermal);
		free_art_trt:
		kfree(priv->trts);

Admin message