Commit 0be51680 authored Apr 09, 2018 by Takashi Iwai

ALSA: cmipci: Allocate with GFP_KERNEL instead of GFP_ATOMIC



save_mixer_state() is called in a sleepable context, so it's safe to
allocate with GFP_KERNEL instead of the current GFP_ATOMIC.  The
GFP_ATOMIC usage must have been based on an incorrect assumption in
the very old code base.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 1fa350b6

sound/pci/cmipci.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1139,7 +1139,7 @@ static int save_mixer_state(struct cmipci *cm)
		struct snd_ctl_elem_value *val;
		unsigned int i;

		val = kmalloc(sizeof(*val), GFP_ATOMIC);
		val = kmalloc(sizeof(*val), GFP_KERNEL);
		if (!val)
		return -ENOMEM;
		for (i = 0; i < CM_SAVED_MIXERS; i++) {

Admin message