Commit 0bdb50c5 authored Jan 06, 2019 by NeilBrown Committed by Mike Snitzer Mar 05, 2019

dm: fix to_sector() for 32bit



A dm-raid array with devices larger than 4GB won't assemble on
a 32 bit host since _check_data_dev_sectors() was added in 4.16.
This is because to_sector() treats its argument as an "unsigned long"
which is 32bits (4GB) on a 32bit host.  Using "unsigned long long"
is more correct.

Kernels as early as 4.2 can have other problems due to to_sector()
being used on the size of a device.

Fixes: 0cf45031 ("dm raid: add support for the MD RAID0 personality")
cc: stable@vger.kernel.org (v4.2+)
Reported-and-tested-by: Guillaume Perréal <gperreal@free.fr>
Signed-off-by: NeilBrown <neil@brown.name>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent d2832376

include/linux/device-mapper.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -603,7 +603,7 @@ do { \
		*/
		#define dm_target_offset(ti, sector) ((sector) - (ti)->begin)

		static inline sector_t to_sector(unsigned long n)
		static inline sector_t to_sector(unsigned long long n)
		{
		return (n >> SECTOR_SHIFT);
		}

Admin message