Commit 0bc2d3c0 authored Apr 21, 2020 by Filipe Manana Committed by David Sterba May 25, 2020

btrfs: remove useless check for copy_items() return value

At btrfs_log_prealloc_extents() we are checking if copy_items() returns a
value greater than 0. That used to happen in the past to signal the caller
that the path given to it was released and reused for other searches, but
as of commit 0e56315c ("Btrfs: fix missing hole after hole punching
and fsync when using NO_HOLES"), the copy_items() function does not have
that behaviour anymore and always returns 0 or a negative value. So just
remove that check at btrfs_log_prealloc_extents(), which the previously
mentioned commit forgot to remove.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 77d5d689

fs/btrfs/tree-log.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -4335,12 +4335,9 @@ static int btrfs_log_prealloc_extents(struct btrfs_trans_handle *trans,
		}
		}
		}
		if (ins_nr > 0) {
		if (ins_nr > 0)
		ret = copy_items(trans, inode, dst_path, path,
		start_slot, ins_nr, 1, 0);
		if (ret > 0)
		ret = 0;
		}
		out:
		btrfs_release_path(path);
		btrfs_free_path(dst_path);

Admin message