PCI / ACPI PM: Propagate wake-up enable for devices w/o ACPI support (0baed8da) · Commits · 戴 / test

Some PCI devices (not PCI Express), like PCI add-on cards, can generate PME#, but they don't have any special platform wake-up support. For this reason, even if they generate PME# to wake up the system from a sleep state, wake-up events are not generated by the platform. It turns out that, at least on some systems, PCI bridges and the PCI host bridge have ACPI GPEs associated with them that, if enabled to generate wake-up events, allow the system to wake up if one of the add-on devices asserts PME# while the system is in a sleep state. Following this observation, if a PCI device without direct ACPI wake-up support is prepared to wake up the system during a transition into a sleep state (eg. suspend to RAM), try to configure the bridges on the path from the device to the root bridge to wake-up the system. Reviewed-by:

Matthew Garrett <mjg59@srcf.ucam.org> Signed-off-by:

Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by:

Jesse Barnes <jbarnes@virtuousgeek.org>

drivers/acpi/sleep.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -691,7 +691,7 @@ int acpi_pm_device_sleep_wake(struct device *dev, bool enable)
		struct acpi_device *adev;
		int error;

		if (!device_may_wakeup(dev))
		if (!device_can_wakeup(dev))
		return -EINVAL;

		handle = DEVICE_ACPI_HANDLE(dev);

drivers/pci/pci-acpi.c

+24 −2

Original line number	Diff line number	Diff line
		@@ -109,10 +109,32 @@ static bool acpi_pci_can_wakeup(struct pci_dev *dev)
		return handle ? acpi_bus_can_wakeup(handle) : false;
		}

		static void acpi_pci_propagate_wakeup_enable(struct pci_bus *bus, bool enable)
		{
		while (bus->parent) {
		struct pci_dev *bridge = bus->self;
		int ret;

		ret = acpi_pm_device_sleep_wake(&bridge->dev, enable);
		if (!ret \|\| bridge->is_pcie)
		return;
		bus = bus->parent;
		}

		/* We have reached the root bus. */
		if (bus->bridge)
		acpi_pm_device_sleep_wake(bus->bridge, enable);
		}

		static int acpi_pci_sleep_wake(struct pci_dev *dev, bool enable)
		{
		return acpi_pci_can_wakeup(dev) ?
		acpi_pm_device_sleep_wake(&dev->dev, enable) : 0;
		if (acpi_pci_can_wakeup(dev))
		return acpi_pm_device_sleep_wake(&dev->dev, enable);

		if (!dev->is_pcie)
		acpi_pci_propagate_wakeup_enable(dev->bus, enable);

		return 0;
		}

		static struct pci_platform_pm_ops acpi_pci_platform_pm = {

Admin message