Commit 0bac71af authored Nov 28, 2011 by Luis R. Rodriguez Committed by John W. Linville Nov 30, 2011

cfg80211: amend regulatory NULL dereference fix



Johannes' patch for "cfg80211: fix regulatory NULL dereference"
broke user regulaotry hints and it did not address the fact that
last_request was left populated even if the previous regulatory
hint was stale due to the wiphy disappearing.

Fix user reguluatory hints by only bailing out if for those
regulatory hints where a request_wiphy is expected. The stale last_request
considerations are addressed through the previous fixes on last_request
where we reset the last_request to a static world regdom request upon
reset_regdomains(). In this case though we further enhance the effect
by simply restoring reguluatory settings completely.

Cc: stable@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@qca.qualcomm.com>
Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent a042994d

net/wireless/reg.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2049,8 +2049,10 @@ static int __set_regdom(const struct ieee80211_regdomain *rd)
		}

		request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx);
		if (!request_wiphy) {
		reg_set_request_processed();
		if (!request_wiphy &&
		(last_request->initiator == NL80211_REGDOM_SET_BY_DRIVER \|\|
		last_request->initiator == NL80211_REGDOM_SET_BY_COUNTRY_IE)) {
		schedule_delayed_work(&reg_timeout, 0);
		return -ENODEV;
		}

Admin message