Commit 0b8a96a3 authored Nov 24, 2020 by Sai Praneeth Prakhya Committed by Will Deacon Nov 25, 2020

iommu: Take lock before reading iommu group default domain type



"/sys/kernel/iommu_groups/<grp_id>/type" file could be read to find out the
default domain type of an iommu group. The default domain of an iommu group
doesn't change after booting and hence could be read directly. But,
after addding support to dynamically change iommu group default domain, the
above assumption no longer stays valid.

iommu group default domain type could be changed at any time by writing to
"/sys/kernel/iommu_groups/<grp_id>/type". So, take group mutex before
reading iommu group default domain type so that the user wouldn't see stale
values or iommu_group_show_type() doesn't try to derefernce stale pointers.

Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: Ashok Raj <ashok.raj@intel.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Sohil Mehta <sohil.mehta@intel.com>
Cc: Robin Murphy <robin.murphy@arm.com>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
Link: https://lore.kernel.org/r/20201124130604.2912899-4-baolu.lu@linux.intel.com


Signed-off-by: Will Deacon <will@kernel.org>

parent 08a27c1c

drivers/iommu/iommu.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -501,6 +501,7 @@ static ssize_t iommu_group_show_type(struct iommu_group *group,
		{
		char *type = "unknown\n";

		mutex_lock(&group->mutex);
		if (group->default_domain) {
		switch (group->default_domain->type) {
		case IOMMU_DOMAIN_BLOCKED:
		@@ -517,6 +518,7 @@ static ssize_t iommu_group_show_type(struct iommu_group *group,
		break;
		}
		}
		mutex_unlock(&group->mutex);
		strcpy(buf, type);

		return strlen(type);

Admin message