Commit 0b5b561c authored Mar 22, 2020 by Michael Chan Committed by David S. Miller Mar 23, 2020

bnxt_en: Return error if bnxt_alloc_ctx_mem() fails.



The current code ignores the return value from
bnxt_hwrm_func_backing_store_cfg(), causing the driver to proceed in
the init path even when this vital firmware call has failed.  Fix it
by propagating the error code to the caller.

Fixes: 1b9394e5 ("bnxt_en: Configure context memory on new devices.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 62d4073e

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -6880,12 +6880,12 @@ skip_rdma:
		}
		ena \|= FUNC_BACKING_STORE_CFG_REQ_DFLT_ENABLES;
		rc = bnxt_hwrm_func_backing_store_cfg(bp, ena);
		if (rc)
		if (rc) {
		netdev_err(bp->dev, "Failed configuring context mem, rc = %d.\n",
		rc);
		else
		return rc;
		}
		ctx->flags \|= BNXT_CTX_FLAG_INITED;

		return 0;
		}

Admin message