Commit 0b4a66a3 authored Jul 17, 2020 by Wang Hai Committed by David S. Miller Jul 17, 2020

nfc: nci: add missed destroy_workqueue in nci_register_device



When nfc_register_device fails in nci_register_device,
destroy_workqueue() shouled be called to destroy ndev->tx_wq.

Fixes: 3c1c0f5d ("NFC: NCI: Fix nci_register_device init sequence")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 12915174

net/nfc/nci/core.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1228,10 +1228,13 @@ int nci_register_device(struct nci_dev *ndev)

		rc = nfc_register_device(ndev->nfc_dev);
		if (rc)
		goto destroy_rx_wq_exit;
		goto destroy_tx_wq_exit;

		goto exit;

		destroy_tx_wq_exit:
		destroy_workqueue(ndev->tx_wq);

		destroy_rx_wq_exit:
		destroy_workqueue(ndev->rx_wq);

Admin message