Commit 0b491904 authored Nov 09, 2019 by Markus Elfring Committed by Tony Lindgren Nov 11, 2019

ARM: OMAP2+: Add missing put_device() call in omapdss_init_of()



A coccicheck run provided information like the following.

arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device;
call of_find_device_by_node on line 258, but without a corresponding
object release within this function.

Generated by: scripts/coccinelle/free/put_device.cocci

Thus add the missed function call to fix the exception handling for
this function implementation.

Fixes: e0c827ac ("drm/omap: Populate DSS children in omapdss driver")
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 7b6560b4

arch/arm/mach-omap2/display.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -265,6 +265,7 @@ static int __init omapdss_init_of(void)
	r = of_platform_populate(node, NULL, NULL, &pdev->dev);		r = of_platform_populate(node, NULL, NULL, &pdev->dev);
	if (r) {		if (r) {
	pr_err("Unable to populate DSS submodule devices\n");		pr_err("Unable to populate DSS submodule devices\n");
			put_device(&pdev->dev);
	return r;		return r;
	}		}

Admin message