Commit 0b2e7886 authored Dec 16, 2015 by Brian Norris Committed by Michael Turquette Dec 31, 2015

clk: gpio: handle error codes for of_clk_get_parent_count()



We might make bad memory allocations if we get (e.g.) -ENOSYS from
of_clk_get_parent_count().

Noticed by Coverity.

Fixes: f66541ba ("clk: gpio: Get parent clk names in of_gpio_clk_setup()")
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Jyri Sarha <jsarha@ti.com>
Cc: Sergej Sawazki <ce3a@gmx.de>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Michael Turquette <mturquette@baylibre.com>

parent c76eb11c

drivers/clk/clk-gpio.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -287,12 +287,14 @@ static void __init of_gpio_clk_setup(struct device_node *node,
		const char **parent_names;
		int i, num_parents;

		num_parents = of_clk_get_parent_count(node);
		if (num_parents < 0)
		return;

		data = kzalloc(sizeof(*data), GFP_KERNEL);
		if (!data)
		return;

		num_parents = of_clk_get_parent_count(node);

		parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL);
		if (!parent_names) {
		kfree(data);

Admin message