Commit 0b2a785d authored Apr 18, 2019 by Guenter Roeck Committed by Eduardo Valentin May 14, 2019

hwmon: (npcm750-pwm-fan) Use devm_thermal_of_cooling_device_register



Use devm_thermal_of_cooling_device_register() to register the cooling
device. As a side effect, this fixes a driver bug:
thermal_cooling_device_unregister() was not called on device removal.

Fixes: f1fd4a4d ("hwmon: Add NPCM7xx PWM and Fan driver")
Cc: Tomer Maimon <tmaimon77@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>

parent 9ebe010e

drivers/hwmon/npcm750-pwm-fan.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -864,10 +864,8 @@ static int npcm7xx_create_pwm_cooling(struct device *dev,
		snprintf(cdev->name, THERMAL_NAME_LENGTH, "%pOFn%d", child,
		pwm_port);

		cdev->tcdev = thermal_of_cooling_device_register(child,
		cdev->name,
		cdev,
		&npcm7xx_pwm_cool_ops);
		cdev->tcdev = devm_thermal_of_cooling_device_register(dev, child,
		cdev->name, cdev, &npcm7xx_pwm_cool_ops);
		if (IS_ERR(cdev->tcdev))
		return PTR_ERR(cdev->tcdev);

Admin message