Commit 0b204161 authored by G Pooja Shamili's avatar G Pooja Shamili Committed by Greg Kroah-Hartman
Browse files

staging: netlogic: Replacing pr_err with dev_err after the call to devm_kzalloc 



The function devm_kzalloc has a first argument of type struct device *.
This is the type of argument required by printing functions such as
dev_info, dev_err, etc. Thus, functions like pr_info should not
normally be used after a call to devm_kzalloc. Thus, all pr_err occurances are
replaced with dev_err function calls

Signed-off-by: default avatarG Pooja Shamili <poojashamili@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8d4cd9c8

drivers/staging/netlogic/xlr_net.c

+9 −5
Original line number Diff line number Diff line
@@ -1028,7 +1028,8 @@ static int xlr_net_probe(struct platform_device *pdev) 
	for (port = 0; port < pdev->num_resources / 2; port++) {

		ndev = alloc_etherdev_mq(sizeof(struct xlr_net_priv), 32);

		if (!ndev) {

			pr_err("Allocation of Ethernet device failed\n");

			dev_err(&pdev->dev,

				"Allocation of Ethernet device failed\n");

			return -ENOMEM;

		}
@@ -1048,7 +1049,8 @@ static int xlr_net_probe(struct platform_device *pdev) 


		res = platform_get_resource(pdev, IORESOURCE_IRQ, port);

		if (!res) {

			pr_err("No irq resource for MAC %d\n", priv->port_id);

			dev_err(&pdev->dev, "No irq resource for MAC %d\n",

				priv->port_id);

			err = -ENODEV;

			goto err_gmac;

		}
@@ -1083,7 +1085,8 @@ static int xlr_net_probe(struct platform_device *pdev) 
		if (strcmp(res->name, "gmac") == 0) {

			err = xlr_gmac_init(priv, pdev);

			if (err) {

				pr_err("gmac%d init failed\n", priv->port_id);

				dev_err(&pdev->dev, "gmac%d init failed\n",

					priv->port_id);

				goto err_gmac;

			}

		}
@@ -1096,7 +1099,8 @@ static int xlr_net_probe(struct platform_device *pdev) 


		err = register_netdev(ndev);

		if (err) {

			pr_err("Registering netdev failed for gmac%d\n",

			dev_err(&pdev->dev,

				"Registering netdev failed for gmac%d\n",

				priv->port_id);

			goto err_netdev;

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE