Commit 0af125ca authored Jan 18, 2013 by Cong Ding Committed by Joerg Roedel Jan 28, 2013

iommu/omap: Remove unnecessary null pointer check



The pointer obj is dereferenced in line 146 and 149 respectively, so it is not
necessary to check null again in line 149 and 175. And I have checked that all
the callers of these two functions guarantee the parameter obj passed is not
null.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Acked-by: Ohad Ben-Cohen <ohad@wizery.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>

parent 949db153

drivers/iommu/omap-iommu.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -146,7 +146,7 @@ static int iommu_enable(struct omap_iommu *obj)
		struct platform_device *pdev = to_platform_device(obj->dev);
		struct iommu_platform_data *pdata = pdev->dev.platform_data;

		if (!obj \|\| !pdata)
		if (!pdata)
		return -EINVAL;

		if (!arch_iommu)
		@@ -172,7 +172,7 @@ static void iommu_disable(struct omap_iommu *obj)
		struct platform_device *pdev = to_platform_device(obj->dev);
		struct iommu_platform_data *pdata = pdev->dev.platform_data;

		if (!obj \|\| !pdata)
		if (!pdata)
		return;

		arch_iommu->disable(obj);

Admin message