Commit 0af10eed authored Aug 12, 2019 by Joshua Clayton Committed by Benjamin Tissoires Sep 18, 2019

HID: core: fix dmesg flooding if report field larger than 32bit

Only warn once of oversize hid report value field

On HP spectre x360 convertible the message:
hid-sensor-hub 001F:8087:0AC2.0002: hid_field_extract() called with n (192) > 32! (kworker/1:2)
is continually printed many times per second, crowding out all else.
Protect dmesg by printing the warning only one time.

The size of the hid report field data structure should probably be increased.
The data structure is treated as a u32 in Linux, but an unlimited number
of bits in the USB hid spec, so there is some rearchitecture needed now that
devices are sending more than 32 bits.

Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

parent aaeabb12

drivers/hid/hid-core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1311,8 +1311,8 @@ u32 hid_field_extract(const struct hid_device hid, u8 report,
		unsigned offset, unsigned n)
		{
		if (n > 32) {
		hid_warn(hid, "hid_field_extract() called with n (%d) > 32! (%s)\n",
		n, current->comm);
		hid_warn_once(hid, "%s() called with n (%d) > 32! (%s)\n",
		__func__, n, current->comm);
		n = 32;
		}

Admin message