soc: qcom: pdr: Constify static qmi structs (0af104d7) · Commits · 戴 / test

Their only usage is to pass their address to qmi_handle_init() which accepts const pointers to both qmi_ops and qmi_msg_handler. Make them const to allow the compiler to put them in read-only memory. Signed-off-by:

Rikard Falkeborn <rikard.falkeborn@gmail.com> Link: https://lore.kernel.org/r/20201122232818.32072-1-rikard.falkeborn@gmail.com Signed-off-by:

Bjorn Andersson <bjorn.andersson@linaro.org>

drivers/soc/qcom/pdr_interface.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -110,7 +110,7 @@ static void pdr_locator_del_server(struct qmi_handle *qmi,
		pdr->locator_addr.sq_port = 0;
		}

		static struct qmi_ops pdr_locator_ops = {
		static const struct qmi_ops pdr_locator_ops = {
		.new_server = pdr_locator_new_server,
		.del_server = pdr_locator_del_server,
		};
		@@ -238,7 +238,7 @@ static void pdr_notifier_del_server(struct qmi_handle *qmi,
		mutex_unlock(&pdr->list_lock);
		}

		static struct qmi_ops pdr_notifier_ops = {
		static const struct qmi_ops pdr_notifier_ops = {
		.new_server = pdr_notifier_new_server,
		.del_server = pdr_notifier_del_server,
		};
		@@ -343,7 +343,7 @@ static void pdr_indication_cb(struct qmi_handle *qmi,
		queue_work(pdr->indack_wq, &pdr->indack_work);
		}

		static struct qmi_msg_handler qmi_indication_handler[] = {
		static const struct qmi_msg_handler qmi_indication_handler[] = {
		{
		.type = QMI_INDICATION,
		.msg_id = SERVREG_STATE_UPDATED_IND_ID,

Admin message