staging: most: cdev: simplify list iteration (0ae9e4f2) · Commits · 戴 / test

This patch uses a less confusing list traversing structure to either return an item of the list that meets the prerequisites or NULL otherwise. Signed-off-by:

Christian Gromm <christian.gromm@microchip.com> Link: https://lore.kernel.org/r/1592815695-19305-7-git-send-email-christian.gromm@microchip.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/most/cdev/cdev.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -66,19 +66,16 @@ static struct comp_channel get_channel(struct most_interface iface, int id)
		{
		struct comp_channel c, tmp;
		unsigned long flags;
		int found_channel = 0;

		spin_lock_irqsave(&ch_list_lock, flags);
		list_for_each_entry_safe(c, tmp, &channel_list, list) {
		if ((c->iface == iface) && (c->channel_id == id)) {
		found_channel = 1;
		break;
		spin_unlock_irqrestore(&ch_list_lock, flags);
		return c;
		}
		}
		spin_unlock_irqrestore(&ch_list_lock, flags);
		if (!found_channel)
		return NULL;
		return c;
		}

		static void stop_channel(struct comp_channel *c)

Admin message