Commit 0ad0b325 authored Jul 01, 2015 by Miklos Szeredi

fuse: initialize fc->release before calling it



fc->release is called from fuse_conn_put() which was used in the error
cleanup before fc->release was initialized.

[Jeremiah Mahler <jmmahler@gmail.com>: assign fc->release after calling
fuse_conn_init(fc) instead of before.]

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Fixes: a325f9b9 ("fuse: update fuse_conn_init() and separate out fuse_conn_kill()")
Cc: <stable@vger.kernel.org> #v2.6.31+

parent b953c0d2

fs/fuse/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1026,6 +1026,7 @@ static int fuse_fill_super(struct super_block sb, void data, int silent)
		goto err_fput;

		fuse_conn_init(fc);
		fc->release = fuse_free_conn;

		fc->dev = sb->s_dev;
		fc->sb = sb;
		@@ -1040,7 +1041,6 @@ static int fuse_fill_super(struct super_block sb, void data, int silent)
		fc->dont_mask = 1;
		sb->s_flags \|= MS_POSIXACL;

		fc->release = fuse_free_conn;
		fc->flags = d.flags;
		fc->user_id = d.user_id;
		fc->group_id = d.group_id;

Admin message