checkpatch: add --strict preference for #defines using BIT(foo) (0ab90191) · Commits · 戴 / test

Using BIT(foo) and BIT_ULL(bar) is more common now. Suggest using these macros over #defines with 1<<value. Add a --fix option too. Signed-off-by:

Joe Perches <joe@perches.com> Cc: David Miller <davem@davemloft.net> Cc: Jiri Pirko <jiri@resnulli.us> Signed-off-by:

scripts/checkpatch.pl

+11 −0

Original line number	Diff line number	Diff line
		@@ -4975,6 +4975,17 @@ sub process {
		}
		}

		# check for #defines like: 1 << <digit> that could be BIT(digit)
		if ($line =~ /#\sdefine\s+\w+\s+$?\s1\s([ulUL])\s\<\<\s(?:\d+\|$Ident)\s*$?/) {
		my $ull = "";
		$ull = "_ULL" if (defined($1) && $1 =~ /ll/i);
		if (CHK("BIT_MACRO",
		"Prefer using the BIT$ull macro\n" . $herecurr) &&
		$fix) {
		$fixed[$fixlinenr] =~ s/$?\s1\s[ulUL]\s<<\s(\d+\|$Ident)\s$?/BIT${ull}($1)/;
		}
		}

		# check for case / default statements not preceded by break/fallthrough/switch
		if ($line =~ /^.\s(?:case\s+(?:$Ident\|$Constant)\s\|default):/) {
		my $has_break = 0;