Commit 0ab7368f authored Aug 28, 2010 by Matt Fleming Committed by Arnaldo Carvalho de Melo Oct 26, 2010

perf record: Remove newline character from perror() argument



If we include a newline character in the string argument to perror()
then the output will be split across two lines like so,

    Unable to read perf file descriptor
    : No space left on device

Deleting the newline character prints a much more readable error,

    Unable to read perf file descriptor: No space left on device

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <89e77b54659bc3798b23a5596c2debb7f6f4cf27.1283010281.git.matt@console-pimps.org>
Signed-off-by: Matt Fleming <matt@console-pimps.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@felicio.ghostprotocols.net>

parent 7f6c1bd5

tools/perf/builtin-record.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -353,7 +353,7 @@ try_again:
		}

		if (read(fd[nr_cpu][counter][thread_index], &read_data, sizeof(read_data)) == -1) {
		perror("Unable to read perf file descriptor\n");
		perror("Unable to read perf file descriptor");
		exit(-1);
		}

		@@ -626,7 +626,7 @@ static int __cmd_record(int argc, const char **argv)

		nr_cpus = read_cpu_map(cpu_list);
		if (nr_cpus < 1) {
		perror("failed to collect number of CPUs\n");
		perror("failed to collect number of CPUs");
		return -1;
		}

Admin message