Commit 0ab163ad authored Feb 06, 2015 by Abhilash Kesavan Committed by Greg Kroah-Hartman Mar 16, 2015

misc: sram: switch to ioremap_wc from ioremap



Currently, the SRAM allocator returns device memory via ioremap.
This causes issues on ARM64 when the internal SoC SRAM allocated by
the generic sram driver is used for audio playback. The destination
buffer address (which is ioremapped SRAM) is not 64-bit aligned for
certain streams (e.g. 44.1k sampling rate). In such cases we get
unhandled alignment faults. Use ioremap_wc in place of ioremap which
gives us normal non-cacheable memory instead of device memory.

Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Tested-by: Tony Lindgren <tony@atomide.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 34644524

drivers/misc/sram.c

+14 −3

Original line number	Diff line number	Diff line
		@@ -69,12 +69,23 @@ static int sram_probe(struct platform_device *pdev)
		INIT_LIST_HEAD(&reserve_list);

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		virt_base = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(virt_base))
		return PTR_ERR(virt_base);
		if (!res) {
		dev_err(&pdev->dev, "found no memory resource\n");
		return -EINVAL;
		}

		size = resource_size(res);

		if (!devm_request_mem_region(&pdev->dev,
		res->start, size, pdev->name)) {
		dev_err(&pdev->dev, "could not request region for resource\n");
		return -EBUSY;
		}

		virt_base = devm_ioremap_wc(&pdev->dev, res->start, size);
		if (IS_ERR(virt_base))
		return PTR_ERR(virt_base);

		sram = devm_kzalloc(&pdev->dev, sizeof(*sram), GFP_KERNEL);
		if (!sram)
		return -ENOMEM;

Admin message