Commit 0a8a2c85 authored Oct 22, 2020 by Sagi Grimberg Committed by Christoph Hellwig Nov 03, 2020

nvme-tcp: avoid repeated request completion



The request may be executed asynchronously, and rq->state may be
changed to IDLE. To avoid repeated request completion, only
MQ_RQ_COMPLETE of rq->state is checked in nvme_tcp_complete_timed_out.
It is not safe, so need adding check IDLE for rq->state.

Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Chao Leng <lengchao@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent fdf58e02

drivers/nvme/host/tcp.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2168,7 +2168,7 @@ static void nvme_tcp_complete_timed_out(struct request *rq)
		struct nvme_ctrl *ctrl = &req->queue->ctrl->ctrl;

		nvme_tcp_stop_queue(ctrl, nvme_tcp_queue_id(req->queue));
		if (!blk_mq_request_completed(rq)) {
		if (blk_mq_request_started(rq) && !blk_mq_request_completed(rq)) {
		nvme_req(rq)->status = NVME_SC_HOST_ABORTED_CMD;
		blk_mq_complete_request(rq);
		}

Admin message