Commit 0a869e8d authored Jul 06, 2019 by Nishka Dasgupta Committed by Eric Anholt Jul 15, 2019

drm/pl111: pl111_vexpress.c: Add of_node_put() before return



Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a break from the middle of the loop there is
no put, thus causing a memory leak. Hence add an of_node_put before the
break.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20190706132742.3250-1-nishkadg.linux@gmail.com

parent 71866a56

drivers/gpu/drm/pl111/pl111_vexpress.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -51,6 +51,7 @@ int pl111_vexpress_clcd_init(struct device *dev,
		}
		if (of_device_is_compatible(child, "arm,hdlcd")) {
		has_coretile_hdlcd = true;
		of_node_put(child);
		break;
		}
		}

Admin message