Commit 0a6a4abc authored Aug 08, 2019 by Andreas Gruenbacher

gfs2: Always mark inode dirty in fallocate



When allocating space with fallocate, always update the file timestamps
and mark the inode dirty, no matter if the FALLOC_FL_KEEP_SIZE flag is
set or not.  The inode needs to be marked dirty so that a subsequent
fsync will pick it up and any new allocations will make it to disk.
Filesystems like xfs and ext4 always update the timestamps, so make
gfs2 behave the same way.

Fixes xfstest generic/483.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

parent d4031259

fs/gfs2/file.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -1065,11 +1065,10 @@ static long __gfs2_fallocate(struct file *file, int mode, loff_t offset, loff_t
		gfs2_quota_unlock(ip);
		}

		if (!(mode & FALLOC_FL_KEEP_SIZE) && (pos + count) > inode->i_size) {
		if (!(mode & FALLOC_FL_KEEP_SIZE) && (pos + count) > inode->i_size)
		i_size_write(inode, pos + count);
		file_update_time(file);
		mark_inode_dirty(inode);
		}

		if ((file->f_flags & O_DSYNC) \|\| IS_SYNC(file->f_mapping->host))
		return vfs_fsync_range(file, pos, pos + count - 1,

Admin message