Commit 0a5f99cf authored Nov 30, 2013 by Ben Hutchings Committed by Jiri Kosina Dec 02, 2013

HID: kye: Fix missing break in kye_report_fixup()



The change to support Genius Manticore Keyboard also changed behaviour
for Genius Gx Imperator Keyboard, as there is no break between the
cases.  This is presumably a mistake.

Reported by Coverity as CID 1134029.

Fixes: 4a2c94c9 ('HID: kye: Add report fixup for Genius Manticore Keyboard')
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 80897aa7

drivers/hid/hid-kye.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -341,6 +341,7 @@ static __u8 kye_report_fixup(struct hid_device hdev, __u8 *rdesc,
		case USB_DEVICE_ID_GENIUS_GX_IMPERATOR:
		rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83,
		"Genius Gx Imperator Keyboard");
		break;
		case USB_DEVICE_ID_GENIUS_MANTICORE:
		rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104,
		"Genius Manticore Keyboard");

Admin message