kbuild: clang: disable unused variable warnings only when constant (0a5f4176) · Commits · 戴 / test

Currently, GCC disables -Wunused-const-variable, but not -Wunused-variable, so warns unused variables if they are non-constant. While, Clang does not warn unused variables at all regardless of the const qualifier because -Wno-unused-const-variable is implied by the stronger option -Wno-unused-variable. Disable -Wunused-const-variable instead of -Wunused-variable so that GCC and Clang work in the same way. Signed-off-by:

Prasad Sodagudi <psodagud@codeaurora.org> Signed-off-by:

Masahiro Yamada <yamada.masahiro@socionext.com>

Makefile

+1 −2

Original line number	Diff line number	Diff line
		@@ -700,7 +700,6 @@ KBUILD_CFLAGS += $(stackp-flag)

		ifeq ($(cc-name),clang)
		KBUILD_CPPFLAGS += $(call cc-option,-Qunused-arguments,)
		KBUILD_CFLAGS += $(call cc-disable-warning, unused-variable)
		KBUILD_CFLAGS += $(call cc-disable-warning, format-invalid-specifier)
		KBUILD_CFLAGS += $(call cc-disable-warning, gnu)
		KBUILD_CFLAGS += $(call cc-disable-warning, address-of-packed-member)
		@@ -718,9 +717,9 @@ else
		# These warnings generated too much noise in a regular build.
		# Use make W=1 to enable them (see scripts/Makefile.extrawarn)
		KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
		KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
		endif

		KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
		ifdef CONFIG_FRAME_POINTER
		KBUILD_CFLAGS += -fno-omit-frame-pointer -fno-optimize-sibling-calls
		else

Admin message