Commit 0a5d1a7f authored Jan 13, 2020 by Wen Yang Committed by Linus Torvalds Jan 13, 2020

mm/page-writeback.c: improve arithmetic divisions

Use div64_ul() instead of do_div() if the divisor is unsigned long, to
avoid truncation to 32-bit on 64-bit platforms.

Link: http://lkml.kernel.org/r/20200102081442.8273-4-wenyang@linux.alibaba.com


Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Qian Cai <cai@lca.pw>
Cc: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent d3ac946e

mm/page-writeback.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1102,7 +1102,7 @@ static void wb_update_write_bandwidth(struct bdi_writeback *wb,
		bw = written - min(written, wb->written_stamp);
		bw *= HZ;
		if (unlikely(elapsed > period)) {
		do_div(bw, elapsed);
		bw = div64_ul(bw, elapsed);
		avg = bw;
		goto out;
		}

Admin message