Commit 0a54ea9f authored Dec 22, 2018 by Kangjie Lu Committed by Greg Kroah-Hartman Jan 15, 2019

staging: rtlwifi: rtl8822b: fix a missing check of alloc_skb



__netdev_alloc_skb() return NULl when it fails. skb_put() further uses
it even when the allocation fails, leading to NULL pointer dereference.
The fix inserts a check for the return value of __netdev_alloc_skb().

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e4abc248

drivers/staging/rtlwifi/rtl8822be/fw.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -486,6 +486,8 @@ bool rtl8822b_halmac_cb_write_data_h2c(struct rtl_priv rtlpriv, u8 buf,

		/* without GFP_DMA, pci_map_single() may not work */
		skb = __netdev_alloc_skb(NULL, size, GFP_ATOMIC \| GFP_DMA);
		if (!skb)
		return false;
		memcpy((u8 *)skb_put(skb, size), buf, size);

		return _rtl8822be_send_bcn_or_cmd_packet(rtlpriv->hw, skb, H2C_QUEUE);

Admin message