rtc: vr41xx: make alarms useful (0a53a167) · Commits · 戴 / test

Currently, the IRQs are disabled when the rtc character device is closed. This means that the device needs to stay open to get alarms while the usual use case will open the device, set the alarm and close the device. Keep the alarms functional on character device release. Note that the PIE are never enabled and would anyway be disabled by the core. Signed-off-by:

Alexandre Belloni <alexandre.belloni@free-electrons.com>

drivers/rtc/rtc-vr41xx.c

+0 −18

Original line number	Diff line number	Diff line
		@@ -119,23 +119,6 @@ static inline void write_elapsed_second(unsigned long sec)
		spin_unlock_irq(&rtc_lock);
		}

		static void vr41xx_rtc_release(struct device *dev)
		{

		spin_lock_irq(&rtc_lock);

		rtc1_write(ECMPLREG, 0);
		rtc1_write(ECMPMREG, 0);
		rtc1_write(ECMPHREG, 0);
		rtc1_write(RTCL1LREG, 0);
		rtc1_write(RTCL1HREG, 0);

		spin_unlock_irq(&rtc_lock);

		disable_irq(aie_irq);
		disable_irq(pie_irq);
		}

		static int vr41xx_rtc_read_time(struct device dev, struct rtc_time time)
		{
		unsigned long epoch_sec, elapsed_sec;
		@@ -272,7 +255,6 @@ static irqreturn_t rtclong1_interrupt(int irq, void *dev_id)
		}

		static const struct rtc_class_ops vr41xx_rtc_ops = {
		.release = vr41xx_rtc_release,
		.ioctl = vr41xx_rtc_ioctl,
		.read_time = vr41xx_rtc_read_time,
		.set_time = vr41xx_rtc_set_time,

Admin message