Commit 0a3d805c authored Dec 21, 2017 by Jon Maloy Committed by David S. Miller Dec 26, 2017

tipc: base group replicast ack counter on number of actual receivers



In commit 2f487712 ("tipc: guarantee that group broadcast doesn't
bypass group unicast") we introduced a mechanism that requires the first
(replicated) broadcast sent after a unicast to be acknowledged by all
receivers before permitting sending of the next (true) broadcast.

The counter for keeping track of the number of acknowledges to expect
is based on the tipc_group::member_cnt variable. But this misses that
some of the known members may not be ready for reception, and will never
acknowledge the message, either because they haven't fully joined the
group or because they are leaving the group. Such members are identified
by not fulfilling the condition tested for in the function
tipc_group_is_enabled().

We now set the counter for the actual number of acks to receive at the
moment the message is sent, by just counting the number of recipients
satisfying the tipc_group_is_enabled() test.

Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b2fb01f4

net/tipc/group.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -368,18 +368,20 @@ void tipc_group_update_bc_members(struct tipc_group *grp, int len, bool ack)
		u16 prev = grp->bc_snd_nxt - 1;
		struct tipc_member *m;
		struct rb_node *n;
		u16 ackers = 0;

		for (n = rb_first(&grp->members); n; n = rb_next(n)) {
		m = container_of(n, struct tipc_member, tree_node);
		if (tipc_group_is_enabled(m)) {
		tipc_group_update_member(m, len);
		m->bc_acked = prev;
		ackers++;
		}
		}

		/* Mark number of acknowledges to expect, if any */
		if (ack)
		grp->bc_ackers = grp->member_cnt;
		grp->bc_ackers = ackers;
		grp->bc_snd_nxt++;
		}

Admin message