dmaengine: dmatest: add a maximum number of test iterations (0a2ff57d) · Commits · 戴 / test

The dmatest usually waits for the killing of its kthreads to stop running tests. This patch adds a parameter that sets a maximum number of test iterations. This feature is quite interesting for debugging when you set a lot of traces in your dmaengine controller driver. Signed-off-by:

Nicolas Ferre <nicolas.ferre@atmel.com> Cc: Haavard Skinnemoen <haavard.skinnemoen@atmel.com> Acked-by:

Maciej Sosnowski <maciej.sosnowski@intel.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Dan Williams <dan.j.williams@intel.com>

drivers/dma/dmatest.c

+14 −1

Original line number	Diff line number	Diff line
		@@ -38,6 +38,11 @@ module_param(max_channels, uint, S_IRUGO);
		MODULE_PARM_DESC(max_channels,
		"Maximum number of channels to use (default: all)");

		static unsigned int iterations;
		module_param(iterations, uint, S_IRUGO);
		MODULE_PARM_DESC(iterations,
		"Iterations before stopping test (default: infinite)");

		static unsigned int xor_sources = 3;
		module_param(xor_sources, uint, S_IRUGO);
		MODULE_PARM_DESC(xor_sources,
		@@ -270,7 +275,8 @@ static int dmatest_func(void *data)

		flags = DMA_CTRL_ACK \| DMA_COMPL_SKIP_DEST_UNMAP \| DMA_PREP_INTERRUPT;

		while (!kthread_should_stop()) {
		while (!kthread_should_stop()
		&& !(iterations && total_tests >= iterations)) {
		struct dma_device *dev = chan->device;
		struct dma_async_tx_descriptor *tx = NULL;
		dma_addr_t dma_srcs[src_cnt];
		@@ -416,6 +422,13 @@ err_srcbuf:
		err_srcs:
		pr_notice("%s: terminating after %u tests, %u failures (status %d)\n",
		thread_name, total_tests, failed_tests, ret);

		if (iterations > 0)
		while (!kthread_should_stop()) {
		DECLARE_WAIT_QUEUE_HEAD(wait_dmatest_exit);
		interruptible_sleep_on(&wait_dmatest_exit);
		}

		return ret;
		}

Admin message