Commit 0a29275b authored by Li RongQing's avatar Li RongQing Committed by Daniel Borkmann
Browse files

bpf: Return -EBADRQC for invalid map type in __bpf_tx_xdp_map



A negative value should be returned if map->map_type is invalid
although that is impossible now, but if we run into such situation
in future, then xdpbuff could be leaked.

Daniel Borkmann suggested:

-EBADRQC should be returned to stay consistent with generic XDP
for the tracepoint output and not to be confused with -EOPNOTSUPP
from other locations like dev_map_enqueue() when ndo_xdp_xmit is
missing and such.

Suggested-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Signed-off-by: default avatarLi RongQing <lirongqing@baidu.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/1578618277-18085-1-git-send-email-lirongqing@baidu.com
parent 3b413041
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -3522,7 +3522,7 @@ static int __bpf_tx_xdp_map(struct net_device *dev_rx, void *fwd,
	case BPF_MAP_TYPE_XSKMAP:
		return __xsk_map_redirect(fwd, xdp);
	default:
		break;
		return -EBADRQC;
	}
	return 0;
}