Commit 0a1eae39 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf tools: Don't keep unreferenced maps when unmaps are detected 



For a file with:

[root@emilia linux-2.6-tip]# perf report -D -fi allmodconfig-j32.perf.data | grep events:
     TOTAL events:      36933
      MMAP events:       9056
      LOST events:          0
      COMM events:       1702
      EXIT events:       1887
  THROTTLE events:          8
UNTHROTTLE events:          8
      FORK events:       1894
      READ events:          0
    SAMPLE events:      22378
      ATTR events:          0
EVENT_TYPE events:          0
TRACING_DATA events:          0
  BUILD_ID events:          0
[root@emilia linux-2.6-tip]#

Testing with valgrind and making perf_session__delete() a nop, so that
we can notice how many maps were actually deleted due to not having any
samples on it:

==== HEAP SUMMARY:

Before:

==10339==     in use at exit: 8,909,997 bytes in 68,690 blocks
==10339==   total heap usage: 78,696 allocs, 10,007 frees, 11,925,853 bytes allocated

After:

==10506==     in use at exit: 8,902,605 bytes in 68,606 blocks
==10506==   total heap usage: 78,696 allocs, 10,091 frees, 11,925,853 bytes allocated

I.e. just 84 detected unmaps with no hits out of 9056 for this workload,
not much, but in some other long running workload this may save more
bytes.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
LKML-Reference: <new-submission>
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 70597f21

tools/perf/util/hist.c

+2 −0
Original line number Diff line number Diff line
@@ -93,6 +93,8 @@ static struct hist_entry *hist_entry__new(struct hist_entry *template) 
	if (self != NULL) {

		*self = *template;

		self->nr_events = 1;

		if (self->ms.map)

			self->ms.map->referenced = true;

		if (symbol_conf.use_callchain)

			callchain_init(self->callchain);

	}

tools/perf/util/map.c

+21 −10
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ void map__init(struct map *self, enum map_type type, 
	self->unmap_ip = map__unmap_ip;

	RB_CLEAR_NODE(&self->rb_node);

	self->groups   = NULL;

	self->referenced = false;

}



struct map *map__new(struct list_head *dsos__list, u64 start, u64 len,
@@ -387,6 +388,7 @@ int map_groups__fixup_overlappings(struct map_groups *self, struct map *map, 
{

	struct rb_root *root = &self->maps[map->type];

	struct rb_node *next = rb_first(root);

	int err = 0;



	while (next) {

		struct map *pos = rb_entry(next, struct map, rb_node);
@@ -402,12 +404,6 @@ int map_groups__fixup_overlappings(struct map_groups *self, struct map *map, 
		}



		rb_erase(&pos->rb_node, root);

		/*

		 * We may have references to this map, for instance in some

		 * hist_entry instances, so just move them to a separate

		 * list.

		 */

		list_add_tail(&pos->node, &self->removed_maps[map->type]);

		/*

		 * Now check if we need to create new maps for areas not

		 * overlapped by the new map:
@@ -415,8 +411,10 @@ int map_groups__fixup_overlappings(struct map_groups *self, struct map *map, 
		if (map->start > pos->start) {

			struct map *before = map__clone(pos);



			if (before == NULL)

				return -ENOMEM;

			if (before == NULL) {

				err = -ENOMEM;

				goto move_map;

			}



			before->end = map->start - 1;

			map_groups__insert(self, before);
@@ -427,14 +425,27 @@ int map_groups__fixup_overlappings(struct map_groups *self, struct map *map, 
		if (map->end < pos->end) {

			struct map *after = map__clone(pos);



			if (after == NULL)

				return -ENOMEM;

			if (after == NULL) {

				err = -ENOMEM;

				goto move_map;

			}



			after->start = map->end + 1;

			map_groups__insert(self, after);

			if (verbose >= 2)

				map__fprintf(after, fp);

		}

move_map:

		/*

		 * If we have references, just move them to a separate list.

		 */

		if (pos->referenced)

			list_add_tail(&pos->node, &self->removed_maps[map->type]);

		else

			map__delete(pos);



		if (err)

			return err;

	}



	return 0;

tools/perf/util/map.h

+2 −1
Original line number Diff line number Diff line
@@ -29,7 +29,8 @@ struct map { 
	};

	u64			start;

	u64			end;

	enum map_type		type;

	u8 /* enum map_type */	type;

	bool			referenced;

	u32			priv;

	u64			pgoff;

CRA Git | Maintained and supported by SUSTech CRA and CCSE