Commit 0a1b8b87 authored by Jens Axboe's avatar Jens Axboe
Browse files

block: make blk_poll() take a parameter on whether to spin or not 



blk_poll() has always kept spinning until it found an IO. This is
fine for SYNC polling, since we need to find one request we have
pending, but in preparation for ASYNC polling it can be beneficial
to just check if we have any entries available or not.

Existing callers are converted to pass in 'spin == true', to retain
the old behavior.

Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e7d94391

block/blk-core.c

+6 −3
Original line number Diff line number Diff line
@@ -1277,19 +1277,22 @@ EXPORT_SYMBOL(submit_bio); 
 * blk_poll - poll for IO completions

 * @q:  the queue

 * @cookie: cookie passed back at IO submission time

 * @spin: whether to spin for completions

 *

 * Description:

 *    Poll for completions on the passed in queue. Returns number of

 *    completed entries found.

 *    completed entries found. If @spin is true, then blk_poll will continue

 *    looping until at least one completion is found, unless the task is

 *    otherwise marked running (or we need to reschedule).

 */

int blk_poll(struct request_queue *q, blk_qc_t cookie)

int blk_poll(struct request_queue *q, blk_qc_t cookie, bool spin)

{

	if (!q->poll_fn || !blk_qc_t_valid(cookie))

		return 0;



	if (current->plug)

		blk_flush_plug_list(current->plug, false);

	return q->poll_fn(q, cookie);

	return q->poll_fn(q, cookie, spin);

}

EXPORT_SYMBOL_GPL(blk_poll);

block/blk-mq.c

+3 −3
Original line number Diff line number Diff line
@@ -38,7 +38,7 @@ 
#include "blk-mq-sched.h"

#include "blk-rq-qos.h"



static int blk_mq_poll(struct request_queue *q, blk_qc_t cookie);

static int blk_mq_poll(struct request_queue *q, blk_qc_t cookie, bool spin);

static void blk_mq_poll_stats_start(struct request_queue *q);

static void blk_mq_poll_stats_fn(struct blk_stat_callback *cb);
@@ -3352,7 +3352,7 @@ static bool blk_mq_poll_hybrid(struct request_queue *q, 
	return blk_mq_poll_hybrid_sleep(q, hctx, rq);

}



static int blk_mq_poll(struct request_queue *q, blk_qc_t cookie)

static int blk_mq_poll(struct request_queue *q, blk_qc_t cookie, bool spin)

{

	struct blk_mq_hw_ctx *hctx;

	long state;
@@ -3392,7 +3392,7 @@ static int blk_mq_poll(struct request_queue *q, blk_qc_t cookie) 


		if (current->state == TASK_RUNNING)

			return 1;

		if (ret < 0)

		if (ret < 0 || !spin)

			break;

		cpu_relax();

	}

drivers/nvme/host/multipath.c

+2 −2
Original line number Diff line number Diff line
@@ -220,7 +220,7 @@ static blk_qc_t nvme_ns_head_make_request(struct request_queue *q, 
	return ret;

}



static int nvme_ns_head_poll(struct request_queue *q, blk_qc_t qc)

static int nvme_ns_head_poll(struct request_queue *q, blk_qc_t qc, bool spin)

{

	struct nvme_ns_head *head = q->queuedata;

	struct nvme_ns *ns;
@@ -230,7 +230,7 @@ static int nvme_ns_head_poll(struct request_queue *q, blk_qc_t qc) 
	srcu_idx = srcu_read_lock(&head->srcu);

	ns = srcu_dereference(head->current_path[numa_node_id()], &head->srcu);

	if (likely(ns && nvme_path_is_optimized(ns)))

		found = ns->queue->poll_fn(q, qc);

		found = ns->queue->poll_fn(q, qc, spin);

	srcu_read_unlock(&head->srcu, srcu_idx);

	return found;

}

fs/block_dev.c

+2 −2
Original line number Diff line number Diff line
@@ -243,7 +243,7 @@ __blkdev_direct_IO_simple(struct kiocb *iocb, struct iov_iter *iter, 
			break;



		if (!(iocb->ki_flags & IOCB_HIPRI) ||

		    !blk_poll(bdev_get_queue(bdev), qc))

		    !blk_poll(bdev_get_queue(bdev), qc, true))

			io_schedule();

	}

	__set_current_state(TASK_RUNNING);
@@ -423,7 +423,7 @@ __blkdev_direct_IO(struct kiocb *iocb, struct iov_iter *iter, int nr_pages) 
			break;



		if (!(iocb->ki_flags & IOCB_HIPRI) ||

		    !blk_poll(bdev_get_queue(bdev), qc))

		    !blk_poll(bdev_get_queue(bdev), qc, true))

			io_schedule();

	}

	__set_current_state(TASK_RUNNING);

fs/direct-io.c

+1 −1
Original line number Diff line number Diff line
@@ -518,7 +518,7 @@ static struct bio *dio_await_one(struct dio *dio) 
		dio->waiter = current;

		spin_unlock_irqrestore(&dio->bio_lock, flags);

		if (!(dio->iocb->ki_flags & IOCB_HIPRI) ||

		    !blk_poll(dio->bio_disk->queue, dio->bio_cookie))

		    !blk_poll(dio->bio_disk->queue, dio->bio_cookie, true))

			io_schedule();

		/* wake up sets us TASK_RUNNING */

		spin_lock_irqsave(&dio->bio_lock, flags);

CRA Git | Maintained and supported by SUSTech CRA and CCSE