Commit 0a12c4a8 authored Aug 11, 2020 by Eric Biggers Committed by Linus Torvalds Aug 12, 2020

fs/minix: fix block limit check for V1 filesystems



The minix filesystem reads its maximum file size from its on-disk
superblock.  This value isn't necessarily a multiple of the block size.
When it's not, the V1 block mapping code doesn't allow mapping the last
possible block.  Commit 6ed6a722 ("minixfs: fix block limit check")
fixed this in the V2 mapping code.  Fix it in the V1 mapping code too.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Qiujun Huang <anenbupt@gmail.com>
Link: http://lkml.kernel.org/r/20200628060846.682158-6-ebiggers@kernel.org


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 32ac86ef

fs/minix/itree_v1.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -29,7 +29,7 @@ static int block_to_path(struct inode * inode, long block, int offsets[DEPTH])
		if (block < 0) {
		printk("MINIX-fs: block_to_path: block %ld < 0 on dev %pg\n",
		block, inode->i_sb->s_bdev);
		} else if (block >= inode->i_sb->s_maxbytes/BLOCK_SIZE) {
		} else if ((u64)block * BLOCK_SIZE >= inode->i_sb->s_maxbytes) {
		if (printk_ratelimit())
		printk("MINIX-fs: block_to_path: "
		"block %ld too big on dev %pg\n",

Admin message