Commit 0a11b9aa authored Aug 02, 2016 by Jeff Mahoney Committed by Linus Torvalds Aug 02, 2016

reiserfs: fix "new_insert_key may be used uninitialized ..."

new_insert_key only makes any sense when it's associated with a
new_insert_ptr, which is initialized to NULL and changed to a
buffer_head when we also initialize new_insert_key.  We can key off of
that to avoid the uninitialized warning.

Link: http://lkml.kernel.org/r/5eca5ffb-2155-8df2-b4a2-f162f105efed@suse.com


Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Jan Kara <jack@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e63e88bc

fs/reiserfs/ibalance.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1153,8 +1153,9 @@ int balance_internal(struct tree_balance *tb,
		insert_ptr);
		}

		memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
		insert_ptr[0] = new_insert_ptr;
		if (new_insert_ptr)
		memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);

		return order;
		}

Admin message